Split CI from build actions, since they're for pretty different use-cases #101
+101
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
force-pushed
the
ci-cd-builds
branch
3 times, most recently
from
616618a to
c614119
Compare
Ivorforce
force-pushed
the
ci-cd-builds
branch
2 times, most recently
from
e35214e to
dfbd1fd
Compare
paddy-exe
reviewed
Nov 17, 2025
Ivorforce
force-pushed
the
ci-cd-builds
branch
from
dfbd1fd to
3ec2fad
Compare
…ases. Reduce CI build combinations to an explicit 5.
Ivorforce
force-pushed
the
ci-cd-builds
branch
from
3ec2fad to
0bc71a5
Compare
paddy-exe
approved these changes
Nov 17, 2025
Collaborator
paddy-exe
left a comment
paddy-exe
left a comment
There was a problem hiding this comment.
Looks great! Thank you for the changes. Took a bit of time for my review 😅
Collaborator
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two different use-cases for GitHub actions in this repository:
The two aren't very compatible, because CI should be quick and minimal, while making builds should run the whole matrix.
#93 attempts to redeem this by fully changing into the CI use-case, but I don't think that is user friendly because cross compiling is difficult, and we want people making GDExtensions to provide builds for all relevant platforms.
For this reason, I split the file into their respective use-cases, hopefully that solves the problem adequately.